#216 Magic incorrectly checks entire path to cell for non-ASCII characters
Issue created by
RTimothyEdwards
This error was surfaced by a user in China who has a home directory which is in Unicode.
Specifically, this setup raises an error in magic where there is a routine that checks for illegal characters in cell names, but is apparently being passed the entire path to the cell. This is incorrect, as only the cell name itself should be checked. It should be easy to fix.
The routine in question is in
commands/CmdSubrs.c
,
CmdIllegalChars()
. It should search for the last slash character in string and start at the character afterward if the result is non-NULL.
(To be clearer: The cell name itself cannot contain Unicode because SPICE and GDS don't support it. But the path component leading up to the cell name can contain Unicode or anything that the filesystem will recognize as a valid directory name.)
RTimothyEdwards/magic