https://open-source-silicon.dev logo
Join Slack
Powered by
Hi <@U016HSAA3RQ>, the efabless precheck passed my...
# shuttle-precheck
m
Hi @User, the efabless precheck passed my application on Friday 18th, but I thought I'd run it again as you have updated it. Now it's failing. Do I need to deal with the issues?
I pulled the latest version and ran locally, and the only issues are SPDX fails on caravel files and a default project name
happy to fix the project name, but won't adding the SDPX header to the caravel files invalidate the consistency checks?
t
Is this a precheck bug? Which files are being flagged for the SPDX header?
m
Caravel/RTL/picorv32 for example
Just left the office so that's from memory
t
That's a precheck script error. We have fixed that before, so I don't know why it crept in again.
m
Ok I will ignore and wait for any instructions in the mpw2 channel
t
I'll let you know. Also @Zeeshan Rafique and anyone else running into this issue.
z
@Tim Edwards should I share the log file of SPDX checks?
Here is the list of files
spdx_compliance_report.log
t
@Zeeshan Rafique: Thanks. What's the URL of your repository so we can check what precheck is doing?
z
I can fix the issue of SPDX warning and can send PR.
t
Sure, if you have a patch. Please communicate with @ahmed nofal
z
Sure.
@ahmed nofal just sent the PR please check.
t
From the logs it appears that your project fails the XOR check, not the SPDX check. SPDX gives a warning, not a failure.
👍 1
@Zeeshan Rafique: I am going to approve the pull request because the SPDX check is flatting warnings on files that the end user shouldn't need to worry about. But it seems that the warnings are making it harder to see what the actual point of failure is.
z
Oh got it.
Thanks.
t
@Zeeshan Rafique: There is also an SPDX header issue in what appears to be your own file 
interactive.tcl
(?) This might cause an actual error. We are pushing your fix to the precheck server so that future runs won't clutter the output with unnecessary warnings. The github precheck has to wait for Jeff to respond, because I don't have authorization to merge the pull request.
@Matt Venn: Related to the above discussion: Do you have any actual SPDX issues, or are the abundance of unnecessary warnings obscuring a different but real error?
z
Yes, I have updated this file locally and just about to push... Thank you for follow up, I will update my repo in next one hour and re-run pre-check on server
a
Hello @Zeeshan Rafique, I have just taken a look at your latest precheck tagged 25june I believe, it fails because of XOR checks. The SPDX compliance checks seem to have confused you a bit. But the main reason your precheck is failing is because it is not passing the XOR check
z
Yes, thanks @ahmed nofal I am about to resolve the issue of XOR checks.
a
Great to hear !!! 🎉
🙌 1
z
@ahmed nofal is there any documentation of pre-checker? I want to know that what does XOR-consistency check do..
a
it checks that your produced wrapper falls within the default user_project_wrapper.gds size, which if irrc is (0,0) lower left corner (2920,3520) upper right corner, right@jeffdi ?
@Manar Abdelatty
m
Not only the size, the xor check makes sure that the pin placement,pin size, core ring matches the gloden wrapper. It deletes everything inside the user project wrapper die area (leaving only the pin extensions outside the die area and the core ring) and xors the output gds against the golden wrapper to make sure that the wrapper boundary (pins and core ring) matches the golden wrapper.
👍 1
z
Great thank you Ahmed and Manar.
@ahmed nofal the scripts for pre-check on server and local are different? If yes then there must the RAM space issue due to which I am getting this error.
Copy code
[06/25/21 11:14:39 PDT] FAIL
            XOR Checks on GDS Failed, Reason: Either you didn't mount the docker, or you ran out of RAM. Otherwise, magic is broken and it segfaulted. Please check: /mnt/uffs/user/u4841_zeeshan/design/Azadi SoC/jobs/mpw_precheck/ea039b86-a103-4867-ad8a-31dc964b9888/magic_xor.log
a
it is due to the fact that your project name has a space in it. Please re create that project but instead call it 
Azadi_SoC
instead
👀 1
z
Done!
I just recreated the project and rerun precheck but its giving exception. Can you check it please @ahmed nofal
a
please give me a git-repo url
m
Also it's super useful if you add and commit anything that changed in the checks directory. That's where the logs of the prechecker tool go
👍 1
a
I believe it is saved, you can access it via your open-galaxy instance (via efabless website -> dashboard -> toolbox -> design/verify)
or do you mean @Zeeshan Rafique should add log files to the project repo on github ?
@Matt Venn
m
Speaking for myself, I'm unlikely to run a precheck on someone else's repo to recreate files they already have. If all the information is easily available, it's more likely IMO to get help from the community. Like writing a good bug report. "It's broken" is likely to just get ignored.
a
Ok now it is clear. I believe in his specific case most likely no logs were created in the checks dir. But yea you are absolutely correct an exhaustive explanation is always required.
👍 1
z
should I push checks folders on repo as well?
a
@Zeeshan Rafique I just ran precheck on your git repo https://github.com/merledu/caravel_azadi_soc.git and it does not result in an exception it is till running as of right now. I am not sure what went wrong, this most likely will require @Greg Shuarette expertise. But please re-initiate a precheck run on it, and lets see if the issue presists
🙌 2
z
Still got Exception
I ran on server, please check
a
yes I checked it. It did return with an exception. This is gonna take extra digging. If it would not be too much to ask. Please re-create the project without editing the name. Just create a new open-mpw-2 project with a name that does not contain spaces in it. Mayb it is something in the project creation flow that is manifested in the precheck. But really I would have to dig deeper to give you a definitive answer. Thank you for being patient about this.
z
Okay np, just creating another project.
a
👍
m
@ahmed nofal so you can see the test results from other people's projects?
z
@Matt Venn he is from management side...
👍 1
TADA: Finally, good to have some green colors...
🙌 1
a
Hey that is awesome ! It was the project right ?
z
Yes, I have created the project again with correct name(without spaces). https://efabless.com/projects/218
🙌 1
@ahmed nofal What should I do with old project? Should I delete that and open request for this project and I have to send the MPW service agreement again?
a
I am not sure about the service agreement really, but yes you would have to stick with the newly created project. @jeffdi might be able to tell us what to do about the MPW service agreement
z
Great Thanks Ahmed...
Open in Slack
PreviousNext
Powered by