Consistency check is crashing with the below backt...
# shuttle-precheck
a
Consistency check is crashing with the below backtrace, on my local machine and in the Github CI action. Ran fine yesterday, all repos are up to date. Any ideas? I wouldn't think schematic / magic / GDS changes could cause this.
Copy code
{{STEP UPDATE}} Executing Check 5 of 13: Consistency
Traceback (most recent call last):
  File "mpw_precheck.py", line 139, in <module>
    default_content='_default_content')
  File "mpw_precheck.py", line 100, in main
    run_precheck_sequence(precheck_config=precheck_config, project_config=project_config)
  File "mpw_precheck.py", line 68, in run_precheck_sequence
    results[check.__surname__] = check.run()
  File "/home/amedcalf/mpw_precheck/check_manager/__init__.py", line 61, in run
    defines_file_path=self.precheck_config['caravel_root'] / 'verilog/rtl/defines.v')
  File "/home/amedcalf/mpw_precheck/checks/consistency_check/consistency_check.py", line 83, in main
    user_netlist_parser = get_netlist_parser(project_config['user_netlist'], project_config['user_module'], project_config['netlist_type'], include_files=include_files, preprocess_define=PREPROCESS_DEFINES)
  File "/home/amedcalf/mpw_precheck/checks/consistency_check/parsers/netlist_parser/__init__.py", line 417, in get_netlist_parser
    return SpiceParser(netlist, top_module)
  File "/home/amedcalf/mpw_precheck/checks/consistency_check/parsers/netlist_parser/__init__.py", line 177, in __init__
    self.instances = [instance.name for instance in subcircuit]
  File "/home/amedcalf/mpw_precheck/checks/consistency_check/parsers/netlist_parser/__init__.py", line 177, in <listcomp>
    self.instances = [instance.name for instance in subcircuit]
AttributeError: 'Comment' object has no attribute 'name'
make: *** [Makefile:114: run-precheck] Error 1
Looks like I had the wrong netlist in netgen/. Extracting from magic now.
The precheck chokes on comments in the spice file. Removed all comment lines and no crash.
t
@jeffdi @mshalan: Can somebody look into the issue of the consistency checks having issues with comment lines in SPICE netlists? @Aidan Medcalf: What format of comments were causing the errors (there are several comment formats, not necessarily shared across different SPICE versions)? Can you share the original netlist (or a failing line from it)?