Shridhar Ambady
10/15/2024, 11:28 PMdlmiles
10/17/2024, 3:03 AMgit am filename
dlmiles
10/17/2024, 3:03 AMFrom 359af1db3bef96872602bc6e7b7c317f2edfba88 Mon Sep 17 00:00:00 2001
From: "Darryl L. Miles" <darryl.miles@REMOVED>
Date: Thu, 10 Oct 2024 17:54:18 +0100
Subject: [PATCH] readline/Makefile: adjustment
The symlink is to a directory so -f is an incorrect test. It will never work.
It doesn't fail because Makefile sees the target 'readline' existing so
doesn't run it again anyway.
No need for subshell ( ) this is not TCL.
Double dollar to escape Makefile $().
It crudley selects the highest readline version number based on ls ordering.
---
readline/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/readline/Makefile b/readline/Makefile
index 8498f5dd..d36d0fcb 100644
--- a/readline/Makefile
+++ b/readline/Makefile
@@ -7,8 +7,8 @@ module: readline readline/libreadline.a readline/libhistory.a
depend:
readline:
- @if ( ! test -f readline/readline ) ; then \
`- ln -s ls | grep readline
readline ; \`
+ @if ! test -e readline/readline ; then \
`+ ln -s ls | grep readline | grep -v "^readline$$" | tail -n1
readline ; \`
fi
readline/libhistory.a: readline/libreadline.a
--
2.43.0
dlmiles
10/17/2024, 3:12 AM