Hi <@U01819B63HP>, The latest version of xschem do...
# xschem
a
Hi @Stefan Schippers, The latest version of xschem doesn't add the X as prefix on the fets when instructed
set lvs_netlist 1; set spiceprefix 1
. I'm developing with gf180mcu. The idea is to evaluate LVS with netgen, so I'm not sure if the strategy should be adding the
X
prefix and
.subckt
declaration in the schematic netlist, or remove it from the layout netlist (I don't know how to do this).
The fets symbol contain
lvs_format=@name @pinlist...
when it should be
lvs_format=@spiceprefix@name @pinlist...
. I guess no fet symbol has it.
s
exactly. Will add the spiceprefix in lvs_format and submit a PR
a
There's any symbol that should not have the X prefix? I will have to fix this on my setup.
s
these symbols do not have a spiceprefix. These don't even have a lvs_format (no difference in netlist for LVS or simulation):
Copy code
diode_dw2ps.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_nd2ps_03v3.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_nd2ps_06v0.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_nw2ps_03v3.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_nw2ps_06v0.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_pd2nw_03v3.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_pd2nw_06v0.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
diode_pw2dw.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
sc_diode.sym:format="@name @pinlist @model area='@r_w * @r_l ' pj='2*@r_w + 2*@r_l ' m=@m"
all others have
@spiceprefix
but you need to fix only n and pfets: (all others don't have
lvs_format
)
Copy code
sed -i 's/lvs_format="@name/lvs_format="@spiceprefix@name/' *fet*.sym
a
Thank's for the script 🙂
s
I have pushed the correction in my gf180mcu pdk fork: https://github.com/StefanSchippers/globalfoundries-pdk-libs-gf180mcu_fd_pr efabless pdk should pull in the changes, there are 4 commits waiting for this since months. https://github.com/efabless/globalfoundries-pdk-libs-gf180mcu_fd_pr
🙌 1
a
Mmm, I think @Tim Edwards could find this interesting
s
I made a pull request some time ago. SInce then I made 3 more commits. I don't know if the original pull request will include these or not. The github is obscure about that and I don't like to invest much time in this
a
I remember Bitbucket allow to "sync" the pull request. At the end, it can be verified on the commit hash.
s
I did invest a minute in Stack Overflow searches and github PR policy is per branch, so: After your pull request is sent, any new commits pushed to your branch will automatically be added to the pull request. This is especially useful if you need to make more changes. So it looks like I don't need to do anything else.
✅ 1
t
@aquiles viza: You changed all of the device names, which is going to break the whole PDK.
a
You mean by the addition of
@spiceprefix
? I remember this was discussed months ago and the solution was the same we discussed at the bottom. I don't see how to perform lvs without the addition of spiceprefix at the beginning of that particular field
t
@aquiles viza: Sorry, that's my fault. I looked at the topmost pull request on the efabless repo and just assumed it was yours, but it isn't.
@Stefan Schippers: I think I may not be getting notifications of pull requests on that repository. I have reviewed and approved your pull request, and will get it merged Monday (after I get back from the FOSSi Latch-Up conference) at the latest.
s
thank you @Tim Edwards. Is that one the right place to submit pull requests? (at least for my part, xschem symbols).
t
Yes, that's the right repo for issues and pull requests.