We have a PDK_ROOT variable set in .bashrc `export...
# ieee-sscs-dc-24
s
We have a PDK_ROOT variable set in .bashrc
export PDK_ROOT=/home/sscspico/miniconda3/share/pdk/
Files contains hardcoded paths which makes it difficult...for anyone not using docker...it will be helpful if you can change it to use a PDK_ROOT variable https://github.com/idea-fasoc/OpenFASOC/blob/main/openfasoc/generators/glayout/glayout/flow/pdk/sky130_mapped/sky130_mapped.py Original Hardcoded :
pdk_root = Path('/usr/bin/miniconda3/share/pdk/')
My Change:
pdk_root = Path('$PDK_ROOT')
and it works... able to set things up without docker in a friend's pc... Please let me know the correct changes...so that we won't face any issue later on pushing code to the repo... @Sakib Pathen @Chetanya Goyal
l
This is a good suggestion
m
Great! Can you send a PR? @Chetanya Goyal @Sakib Pathen fyi
1
c
I don't think this is a good idea from a user perspective. Someone who doesn't know about exporting environment variables might have trouble exporting pdk root if they used docker. It you would like to PR, you can try and implement a simple if condition is the file you sent which checks both locations
s
@Chetanya Goyal
PDK_ROOT
is a variable which is also used by other open source tools...xschem is one I know of https://xschem.sourceforge.io/stefan/xschem_man/tutorial_xschem_sky130.html#:~:text=PDK_ROOT%20and%20PDK%20environment%20variables I can see that
PDK_ROOT
has also been created in docker installation...
Copy code
root@c4f43b781ddd:~# $PDK_ROOT
bash: /usr/bin/miniconda3/share/pdk/: Is a directory
The glayout installation scripts has it...not what i came up with...let me know what you think...I am not doing any PR yet